Skip to content

[None][infra] Waive remaining AutoDeploy Disagg tests until fix lands#15282

Merged
govind-ramnarayan merged 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:gramnarayan/waive-ad-disagg-trtllm-serve
Jun 12, 2026
Merged

[None][infra] Waive remaining AutoDeploy Disagg tests until fix lands#15282
govind-ramnarayan merged 2 commits into
NVIDIA:mainfrom
nv-auto-deploy:gramnarayan/waive-ad-disagg-trtllm-serve

Conversation

@govind-ramnarayan

@govind-ramnarayan govind-ramnarayan commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

A fix is expected in #15260 after which all AutoDeploy disagg tests should be unwaiveable.

Summary by CodeRabbit

  • Tests
    • Updated internal test waivers for disaggregated and async scenarios to improve test coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@govind-ramnarayan
[https://nvbugs/6306936][fix] Waive AutoDeploy disagg serve smoke
12fdc76 
Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
@govind-ramnarayan
[https://nvbugs/6306936][fix] Waive remaining AutoDeploy disagg tests
bff01fe 
Signed-off-by: Govind Ramnarayan <105831528+govind-ramnarayan@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR expands the test waiver list in tests/integration/test_lists/waives.txt by adding SKIP waivers for async/eagle3 handoff scenarios and a TRTLLM OpenAI completion test while preserving existing waivers for chunked prefill, logits, reduced-layer, and tinyllama batch-handoff cases.

Changes

Test waiver list update

Layer / File(s) Summary
Disaggregated test async/eagle3 and TRTLLM waivers
tests/integration/test_lists/waives.txt		 Expands SKIP-waiver block for disaggregated/test_ad_disagg.py with new async/eagle3 scenarios (full-model handoff, generation matching, no-overlap matching, sharded generation handoff) while retaining existing chunked prefill, logits, reduced-layer, and tinyllama batch-handoff waivers; adds new SKIP waiver for disaggregated/test_ad_disagg_trtllm_serve.py::test_openai_completion.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#15250: Updates tests/integration/test_lists/waives.txt with SKIP waivers for disaggregated-related test cases.
  • NVIDIA/TensorRT-LLM#15273: Modifies the same waives.txt file by adding/removing SKIP waivers for disaggregated/test_ad_disagg* handoff and logits test cases.
  • NVIDIA/TensorRT-LLM#15061: Updates tests/integration/test_lists/waives.txt by managing SKIP waiver entries for disaggregated and related test cases.

Suggested reviewers

  • tburt-nv
  • bmarimuthu-nv
  • dpitman-nvda
  • 2ez4bz
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete and vague. Only a brief statement about a pending fix is provided, with no substantive explanation of the changes or why they are necessary. Provide a clear description explaining what tests are being waived, why they are being waived, and reference the NVBugs ticket (6306936) and the pending fix (PR #15260) more explicitly.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main change: adding waivers for remaining AutoDeploy Disagg tests until a fix is implemented.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@govind-ramnarayan govind-ramnarayan changed the title [None][infra] Waive remaining AutoDeploy Disagg tests until fix lands [None][infra] Waive remaining AutoDeploy Disagg tests until fix lands Jun 11, 2026
@govind-ramnarayan

govind-ramnarayan commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "waive only"

@tensorrt-cicd

tensorrt-cicd commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #53728 [ skip ] triggered by Bot. Commit: bff01fe Link to invocation

@tensorrt-cicd

tensorrt-cicd commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

PR_Github #53728 [ skip ] completed with state SUCCESS. Commit: bff01fe
Skipping testing for commit bff01fe

Link to invocation

@govind-ramnarayan govind-ramnarayan merged commit 5a77356 into NVIDIA:main Jun 12, 2026
19 of 26 checks passed
This was referenced Jun 12, 2026
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@2ez4bz 2ez4bz 2ez4bz approved these changes

Assignees

@govind-ramnarayan govind-ramnarayan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@govind-ramnarayan @tensorrt-cicd @2ez4bz